New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: add autofix npm script #12330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Probably overthinking this, but: Should we handle differently in case this is called from CI? (It shouldn't be, but...)
@platinumazure Mind elaborating on what you mean? Not sure I understand. Thanks! |
I was just wondering if we wanted to have an environment variable check in that task, where if the task was called from CI, then it should throw an error. As I type this, I'm thinking not, so go ahead and just ignore what I said. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
This adds a
fix
flag to thelint
task inMakefile.js
and adds afix
npm script as a small convenience for contributors.Is there anything you'd like reviewers to focus on?
Nothing in particular!