Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add suggestions API #12384
New: Add suggestions API #12384
Changes from 10 commits
ede4b0f
b2e6419
3ab339a
aa99818
d24afff
36d2b3b
6f904f0
e28066c
44ea3cb
6415998
142b138
3fdc232
a08a135
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented suggestions support for
messageId
s. Do we want to do it this way, or should it be a different key and different format in themeta
info? For example, I could easily change this to bedescriptionId
and put the associated descriptions inmeta.suggestionDescriptions
or something instead of overloadingmeta.messages
andmessageId
s. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question!
I don't have a problem with reusing
meta.messages
itself, but I would be curious to know if other team members think it could be confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
meta.messages
as general-purpose bucket for i18n. So I think it should be fine to just reuse it.