Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Disable require-await for async generators (fixes #12459) #12484

Closed
wants to merge 2 commits into from
Closed

Update: Disable require-await for async generators (fixes #12459) #12484

wants to merge 2 commits into from

Conversation

dmitryrn
Copy link

@dmitryrn dmitryrn commented Oct 23, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule

What changes did you make? (Give an overview)
I disabled require-await for async generators. #12459

Is there anything you'd like reviewers to focus on?
Should documentation of require-await updated somehow?

@jsf-clabot
Copy link

jsf-clabot commented Oct 23, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 23, 2019
@dmitryrn dmitryrn changed the title Disablerequire await for async generator Update: Disable require-await for async generators (fixes #12459) Oct 23, 2019
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Dec 4, 2019
@mdjermanovic
Copy link
Member

Thanks for the PR! Labeling as accepted because the related issue is accepted.

Should documentation of require-await updated somehow?

I think it would be good to update the documentation, maybe just with a short note that the rule doesn't check async generators.

Would also like to doublecheck with the team:

  • Is it accepted to skip all async generators or just those with yield *? (and if all, it would be nice to add a test without yield *).
  • Update: looks appropriate, although this change produces fewer errors?

@kaicataldo
Copy link
Member

@dmitryrn Friendly ping

@kaicataldo
Copy link
Member

One more friendly ping

@mdjermanovic
Copy link
Member

Assuming it was accepted to ignore all async generators regardless of any other conditions, the change in the code looks good!

It would be nice to add just two small details:

  • A valid test case with an async generator that doesn't have yield * (and isn't empty and doesn't have await).
  • A sentence in the documentation saying that this rule doesn't check async generators.

@kaicataldo
Copy link
Member

@dmitryrn Friendly ping. Are you willing to continue working on this?

@kaicataldo
Copy link
Member

Closing this in favor of #13048 since we haven't heard back from the PR author.

@kaicataldo kaicataldo closed this Mar 28, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 25, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants