New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Disable require-await for async generators (fixes #12459) #12484
Update: Disable require-await for async generators (fixes #12459) #12484
Conversation
require await
for async generator
Thanks for the PR! Labeling as accepted because the related issue is accepted.
I think it would be good to update the documentation, maybe just with a short note that the rule doesn't check async generators. Would also like to doublecheck with the team:
|
@dmitryrn Friendly ping |
One more friendly ping |
Assuming it was accepted to ignore all async generators regardless of any other conditions, the change in the code looks good! It would be nice to add just two small details:
|
@dmitryrn Friendly ping. Are you willing to continue working on this? |
Closing this in favor of #13048 since we haven't heard back from the PR author. |
What is the purpose of this pull request? (put an "X" next to item)
[X] Changes an existing rule
What changes did you make? (Give an overview)
I disabled
require-await
for async generators. #12459Is there anything you'd like reviewers to focus on?
Should documentation of
require-await
updated somehow?