New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: support specifying extensions in the config (fixes #10828) #12555
Conversation
Hi, @g-plane. Thank you for your work! However, this direction is different a bit from the current consensus. As mentioned in #10828 (comment), we have RFC20 and RFC22 as approved approach. If you want to support the |
It's still in progress so it may be different with RFC, however, this PR is modeled after RFC20. Is this direction wrong? |
It's no problem if the add of the To make sure, RFC20 doesn't add any property to config files. |
So should I close this if it's too early? |
No, feel free to continue to work on this. Just I wanted to clarify. |
Should I send an RFC about adding this property before continuing? |
|
What is the purpose of this pull request? (put an "X" next to item)
Add something to the core
What changes did you make? (Give an overview)
Support specifying extensions in configuration files.
The
extensionRegExp
property onFileEnumerator
instance is removed. Instead,getExtensionRegExp
method is introduced. (This isn't a breaking change because it isn't part of public APIs.)This enables that ESLint reads configuration file and retrieves extensions on demand, instead of generating
extensionRegExp
in the constructor ofFileEnumerator
.Is there anything you'd like reviewers to focus on?
.js
is always included. Is this behavior correct? Or should it be overrided?