Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: improve suggestion testing experience #12602

Merged
merged 1 commit into from Dec 20, 2019
Merged

Update: improve suggestion testing experience #12602

merged 1 commit into from Dec 20, 2019

Commits on Nov 25, 2019

  1. Fix: improve suggestion testing experience 

    Previously you had to explicitly pass the exact same value (undefined), which meant either explicitly set `suggestions: undefined`, or omit the property.
I hate writing `undefined`, but I prefer to be explicit in my tests and say "I expect no suggestions".
Now you can pass any falsey, or an empty array, and the rule tester will perform as expected.
    @bradzacher
    bradzacher committed Nov 25, 2019
    Copy the full SHA
    a00c108 View commit details
    Browse the repository at this point in the history