Chore: remove unused code in max-lines-per-function #12659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x ] Other, please explain:
What changes did you make? (Give an overview)
remove unused code in max-lines-per-function.
eslint/lib/rules/max-lines-per-function.js
Lines 57 to 59 in 8108f49
Because the return value from
sourceCode.getAllComments()
is always truthy, checking falsy is useless.eslint/lib/rules/line-comment-position.js
Lines 89 to 93 in 219aecb
eslint/lib/rules/capitalized-comments.js
Lines 294 to 296 in 8108f49
Is there anything you'd like reviewers to focus on?