Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove bundling of ESLint during release #12676

Merged
merged 1 commit into from Dec 18, 2019
Merged

Chore: remove bundling of ESLint during release #12676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 2 additions & 11 deletions Makefile.js
View file
Open in desktop
Expand Up @@ -560,7 +560,7 @@ target.mocha = () => {
target.karma = () => {
echo("Running unit tests on browsers");

target.webpack();
target.webpack("production");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it would be better to test against the production build in our Karma tests.


const browserFileLintOutput = new CLIEngine({
useEslintrc: false,
Expand Down Expand Up @@ -775,16 +775,7 @@ target.gensite = function(prereleaseVersion) {
echo("> Removing the temporary directory (Step 12)");
rm("-rf", TEMP_DIR);

// 13. Update demos, but only for non-prereleases
if (!prereleaseVersion) {
echo("> Updating the demos (Step 13)");
target.webpack("production");
cp("-f", "build/eslint.js", `${SITE_DIR}src/js/eslint.js`);
} else {
echo("> Skipped updating the demos (Step 13)");
}

// 14. Create Example Formatter Output Page
// 13. Create Example Formatter Output Page
echo("> Creating the formatter examples (Step 14)");
generateFormatterExamples(getFormatterResults(), prereleaseVersion);

Expand Down