Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: drop Node.js 8 support (refs eslint/rfcs#44) #12700

Merged
merged 4 commits into from Jan 7, 2020
Merged

Breaking: drop Node.js 8 support (refs eslint/rfcs#44) #12700

merged 4 commits into from Jan 7, 2020

Commits on Dec 22, 2019

  1. Breaking: drop Node.js 8 support (refs eslint/rfcs#44)

    @mysticatea
    mysticatea committed Dec 22, 2019
    Copy the full SHA
    ed32c70 View commit details
    Browse the repository at this point in the history

  2. update isCombiningCharacter() function 

    because Unicode Property Escapes is supported since Node.js 10.0.0.
    @mysticatea
    mysticatea committed Dec 22, 2019
    Copy the full SHA
    2ba617b View commit details
    Browse the repository at this point in the history

  3. fix a lint setting 

    is-combining-character.js was auto-generated file, so it was not linted.
But the previous commit makes the file is a regular file, so we should
lint it.
    @mysticatea
    mysticatea committed Dec 22, 2019
    Copy the full SHA
    de38836 View commit details
    Browse the repository at this point in the history

  4. sort the lint results in tests 

    because memfs may privide file list in different orders.
    @mysticatea
    mysticatea committed Dec 22, 2019
    Copy the full SHA
    f5368ac View commit details
    Browse the repository at this point in the history