Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: no-loss-of-precision (fixes #11279) #12747
New: no-loss-of-precision (fixes #11279) #12747
Changes from 11 commits
bece581
f95678e
dd9d66d
a02acc2
7258cbd
479767b
f4864e9
64a61bf
d8edf52
1f4b1ea
3a9be96
e7ca7b7
6238203
56f1aae
ef8ec88
5fcd473
a6e3df8
bb40fb4
3a0d251
4fb6481
f293b93
ff1e610
9eccda2
ec9b14e
76179a2
d39d8e4
e82aaf5
4398188
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
.endsWith
here seems a bit weird, although I can't think of any cases where it would be incorrect.Can you add some tests that use leading zeros on non-base-10 literals (e.g.
0x005f
) to make sure the rule doesn't report an error?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.