Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add prerequisites checklist to PR template #12790

Merged
merged 3 commits into from Jan 16, 2020
Merged

Chore: add prerequisites checklist to PR template #12790

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fd03fa
Chore: add prerequisites checklist to PR template
kaicataldo Jan 14, 2020
3836f21
Add friendly message at top
kaicataldo Jan 14, 2020
ef82751
Address feedback
kaicataldo Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
@@ -1,8 +1,15 @@
<!--
Thank you for contributing!

ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).
-->

**What is the purpose of this pull request? (put an "X" next to item)**
#### Prerequisites checklist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were changed because markdownlint now warns on using emphasized text as headers (MD036/no-emphasis-as-heading/no-emphasis-as-header). This should look the same to the end user.


- [ ] I have read the [contributing guidelines](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md).
aladdin-add marked this conversation as resolved.
Show resolved Hide resolved
- [ ] The team has reached consensus on the changes proposed in this pull request. If not, I understand that the process will begin with this pull request and won't be merged until it has been accepted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical, but could this say "I understand that the [evaluation/consensus] process will begin with this pull request and won't be merged until it has been accepted"?

Also, I think we're conflating "team has reached consensus" with "issue is accepted". This is correct from the perspective of our process, but a newcomer may not understand that intuitively. It would be great if we could use the same verb phrase throughout the sentence, to the extent it is feasible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Updated - please let me know what you think.


#### What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))
Expand All @@ -29,9 +36,7 @@
The following is required for all pull requests:
-->

**What changes did you make? (Give an overview)**


**Is there anything you'd like reviewers to focus on?**
#### What changes did you make? (Give an overview)


#### Is there anything you'd like reviewers to focus on?