Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confusing error message. #13014

Closed
wants to merge 1 commit into from
Closed

Fix confusing error message. #13014

wants to merge 1 commit into from

Conversation

ahoseinian
Copy link

the problem here was even if the assertion on messageId fails in the error it reads should have desc of:

Prerequisites checklist

What is the purpose of this pull request?

  • Other, please explain:

this PR fixes a small naming issue in RuleTester suggestions test error output.

@ahoseinian
Fix confusing error message.
e3852c1 
the problem here was even if the assertion on `messageId` fails in the error it reads `should have desc of`:
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 7, 2020
@mdjermanovic mdjermanovic added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Mar 7, 2020
@mdjermanovic
Copy link
Member

Thanks for the PR!

You're right, this is a bug and the fix looks good.

I'm marking this as "evaluating" only because there is another PR #12635 which also fixes this bug (among other things), so I'm not sure at the moment should we merge this first or just wait for #12635 to be merged.

@kaicataldo
Copy link
Member

#12635 has been merged. Should we close this PR? @ahoseinian Thank you for contributing!

@ahoseinian ahoseinian closed this Mar 20, 2020
@ahoseinian ahoseinian deleted the patch-1 branch March 20, 2020 08:21
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 18, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahoseinian @mdjermanovic @kaicataldo