Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: consistencies with docs default and rule #13035

Closed
wants to merge 1 commit into from

Conversation

anikethsaha
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

There is an inconsistency with the default mentioned in docs and in the rule schema for rule

  • use-isnan
  • computed-property-spacing

What changes did you make? (Give an overview)

  • use-isnan: In docs check the enforceForSwitchCase which is mentioned false in docs but true in rule schema

  • computed-property-spacing : In docs check the enforceForClassMembers which is mentioned as false in docs but true in rule schema

I did change the rule schema and the required tests as the docs were correct in there place.

Is there anything you'd like reviewers to focus on?

This was noticed when I was working in this #13034

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 12, 2020
@mdjermanovic
Copy link
Member

These default values were recently changed in #12913 and #12915. The new defaults will apply starting from v7.0.0

Documentation is also updated for v7.0.0:

So, the actual code in master is correct.

Links on https://eslint.org/docs/rules/ are for v6.8.0

@anikethsaha anikethsaha deleted the fix-default-rule branch March 12, 2020 13:50
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 10, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants