Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: added async in allow method in no-empty-function (fixes #12768) #13036

Merged
merged 8 commits into from Mar 20, 2020
Merged

Fix: added async in allow method in no-empty-function (fixes #12768) #13036

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abfcd69
Fix: added async in allow method in no-empty-function
anikethsaha Mar 12, 2020
9d918ef
Chore: added tests for async* allow
anikethsaha Mar 13, 2020
897773c
Docs: updated docs for async method and funct
anikethsaha Mar 15, 2020
1373f02
Chore: more tests and test fixes and docs refactore
anikethsaha Mar 17, 2020
7d9974a
Update docs/rules/no-empty-function.md
anikethsaha Mar 17, 2020
c773fed
Update docs/rules/no-empty-function.md
anikethsaha Mar 17, 2020
8221992
Update docs/rules/no-empty-function.md
anikethsaha Mar 17, 2020
c39f260
Docs: fixed the ecma version for docs snippet
anikethsaha Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/rules/no-empty-function.js
View file
Open in desktop
Expand Up @@ -23,7 +23,9 @@ const ALLOW_OPTIONS = Object.freeze([
"generatorMethods",
"getters",
"setters",
"constructors"
"constructors",
"asyncFunctions",
"asyncMethods"
]);

/**
Expand Down
14 changes: 13 additions & 1 deletion tests/lib/rules/no-empty-function.js
View file
Open in desktop
Expand Up @@ -24,7 +24,9 @@ const ALLOW_OPTIONS = Object.freeze([
"generatorMethods",
"getters",
"setters",
"constructors"
"constructors",
"asyncFunctions",
"asyncMethods"
]);

/**
Expand Down Expand Up @@ -267,6 +269,16 @@ ruleTester.run("no-empty-function", rule, [
{
code: "var foo = () => 0;",
parserOptions: { ecmaVersion: 6 }
},
{
code: "const foo = { async method() {} }",
anikethsaha marked this conversation as resolved.
Show resolved Hide resolved
options: [{ allow: ["asyncMethods"] }],
parserOptions: { ecmaVersion: 8 }
},
{
code: "async function a(){}",
options: [{ allow: ["asyncFunctions"] }],
parserOptions: { ecmaVersion: 8 }
anikethsaha marked this conversation as resolved.
Show resolved Hide resolved
}
],
invalid: []
Expand Down