Docs: Clarify that node_modules is ignored by default #13054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
MKuijpers
changed the title
MKuijpers
changed the title
kaicataldo
approved these changes
Mar 17, 2020
kaicataldo
added
documentation
|
Thanks for doing this! Agreed that this is an improvement. |
anikethsaha
pushed a commit
to anikethsaha/eslint
that referenced
this pull request
Mar 23, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13006
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
The
node_modulesfolder is ignored by default. However, in some parts of the documentation it is still included in ignore configs. I removed thenode_modulesentries from the examples and clarified in an example ignore config how it can be added back in.Is there anything you'd like reviewers to focus on?
Whether the added/edited documentation is still correct and if
node_modules/*is the correct pattern.