Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: levn@0.4.1 (fixes #9366) #13140

Merged
merged 4 commits into from Apr 7, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -69,7 +69,7 @@
"is-glob": "^4.0.0",
"js-yaml": "^3.13.1",
"json-stable-stringify-without-jsonify": "^1.0.1",
"levn": "^0.3.0",
"levn": "^0.4.1",
"lodash": "^4.17.14",
"minimatch": "^3.0.4",
"natural-compare": "^1.4.0",
Expand Down
28 changes: 26 additions & 2 deletions tests/lib/linter/linter.js
Expand Up @@ -2733,14 +2733,38 @@ describe("Linter", () => {
});

describe("when evaluating code with comments which have colon in its value", () => {
const code = "/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: \"data:image\\/|\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-\"}] */\nalert('test');";
const code = String.raw`
/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: "data:image\/|\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-"}] */
alert('test');
`;

it("should not parse errors, should report a violation", () => {
const messages = linter.verify(code, {}, filename);

assert.strictEqual(messages.length, 1);
assert.strictEqual(messages[0].ruleId, "max-len");
assert.strictEqual(messages[0].message, "This line has a length of 122. Maximum allowed is 100.");
assert.strictEqual(messages[0].message, "This line has a length of 128. Maximum allowed is 100.");
assert.include(messages[0].nodeType, "Program");
});
});

describe("when evaluating code with comments that contain escape sequences", () => {
const code = String.raw`
/* eslint max-len: ["error", 1, { ignoreComments: true, ignorePattern: "console\.log\\(" }] */
console.log("test");
var a = "test2";
`;

it("should validate correctly", () => {
const config = { rules: {} };

const messages = linter.verify(code, config, filename);

assert.strictEqual(messages.length, 1);
assert.strictEqual(messages[0].ruleId, "max-len");
assert.strictEqual(messages[0].message, "This line has a length of 16. Maximum allowed is 1.");
assert.strictEqual(messages[0].line, 4);
assert.strictEqual(messages[0].column, 1);
assert.include(messages[0].nodeType, "Program");
});
});
Expand Down