Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Initialize ESLint for a TS project by analysing codebase (fixes… #13150

Closed
wants to merge 1 commit into from

Conversation

rajat1saxena
Copy link

#13149)

It fixes the issue where ESLint encounters an error while generating eslintrc file if you have a TypeScript project and you chose the option 'Inspect your JavaScript file(s)' from the initialization wizard.

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

In lib/init/autoconfig.js I changed line #336 to set newConfig.extends to an array containing RECOMMENDED_CONFIG_NAME instead of just setting it to RECOMMENDED_CONFIG_NAME.

Is there anything you'd like reviewers to focus on?

Nope

…slint#13149)

It fixes the issue where ESLint encounters an error while generating eslintrc file if you have a TypeScript project and you chose the option 'Inspect your JavaScript file(s)' from the initialization wizard.
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 6, 2020
@kaicataldo
Copy link
Member

Thank you for the PR. This appears to be a dupe of #12738, which has now been merged, so I'm closing this. We appreciate your contribution!

@kaicataldo kaicataldo closed this Apr 6, 2020
@rajat1saxena rajat1saxena changed the title Fix: Initialize ESLint for a TS project by anaylysing codebase (fixes… Fix: Initialize ESLint for a TS project by analysing codebase (fixes… Apr 7, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 4, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants