Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove default .js from --ext CLI option #13176

Merged
merged 1 commit into from Apr 23, 2020
Merged

Fix: Remove default .js from --ext CLI option #13176

merged 1 commit into from Apr 23, 2020

Commits on Apr 14, 2020

  1. Fix: Remove default .js from --ext CLI option 

    PR #12677, `Breaking: lint overrides files`, removed the default `.js`
value from the  default CLIEngine options. However, it did not remove
the same default value from the `--ext` option parsed by Optionator.
Because of this, when running `eslint .` without the `--ext` option,
Optionator would insert a default `--ext .js` value that would be passed
on to the CLIEngine. ESLint only lints `overrides` files if the `--ext`
CLI option is not passed, so the default `--ext .js` option prevented
ESLint from ever reaching the `overrides` file path checking flow.
    @btmills
    btmills committed Apr 14, 2020
    Copy the full SHA
    e8b6199 View commit details
    Browse the repository at this point in the history