New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: treat all literals like boolean literal in no-constant-condition #13245
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3afc750
Fix: treet all literals like boolean literal in no-constant-condition
Zzzen 96d0834
fix unexpected short circuit
Zzzen 540bb20
handle bigin/regex on unsupported runtime
Zzzen 6eb51a8
Merge remote-tracking branch 'eslint/master'
Zzzen 17787ea
fix bigint tests
Zzzen b0c2e70
simplify literal truthiness
Zzzen c4c8426
handle regex literal in unsupported environments
Zzzen ce019be
Update lib/rules/no-constant-condition.js
Zzzen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#11308 did not handle following code:
demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed a bug that should be fixed whether or not #13238 gets accepted.
Could we maybe also this:
replace with just
inBooleanPosition
?I think it might fix similar bugs, such as:
Though, it seems that the whole condition starting with
node.operator === "||" &&
might be removed in this PR (if #13238 gets accepted), but we should also doublecheck what's happening with the recursion inisLogicalIdentity
. It already looks buggy in the actual version:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cause is an inappropriate propagation of short circuit.
fixed in 96d0834