New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: allowFunctionParams option in no-underscore-dangle (fixes 12579) #13545
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6f7c222
#12579 add allowFunctionParams option
sunghyunjo ad72c3f
#12579 edit doc & function name
sunghyunjo 0951da6
#12579 add test case
sunghyunjo a5d7370
#12579 add allowFunctionParam rule in docs
sunghyunjo 1d12aea
#12579 Update : test case when option is false
sunghyunjo 5109bf0
Return to origin code
sunghyunjo 03689ba
Remove comments
sunghyunjo b1ef8db
Edit what was reviewed
sunghyunjo 1703293
Update: Destructuring param test
4f1b8cf
Update: invalid test case
fbdc7fd
Change initial state to true
sunghyunjo 64911e9
#12579 Update: Edit what was reviewed
a849734
Merge branch 'issue/#12579' of https://github.com/sunghyunjo/eslint i…
c50c6d5
#12579 Fix a typo
sunghyunjo 7e9ccea
#12579 Update : allow option
sunghyunjo 850c80f
#12579 Update: Edit what was reviewed
7423641
#12579 Update : check type of param
sunghyunjo 7667054
#12579 Simplify the code
sunghyunjo 1da8418
Update : test case
sunghyunjo 39f89e2
Fix : ...bar -> ..._bar
sunghyunjo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make more sense, it should defaults to
false
. we can change it in next major release( as it's a breaking change). 😄