Update: support numeric separators (refs #13568) #13581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
rule
I suppose that would be in a separate PR #13568 (comment) |
mdjermanovic
commented
Aug 18, 2020
| const DECIMAL_INTEGER_PATTERN = /^(0|[1-9]\d*)$/u; | ||
| const DECIMAL_INTEGER_PATTERN = /^(0|[1-9](?:_?\d)*)$/u; |
There was a problem hiding this comment.
This actually had a bug: it doesn't recognize NonOctalDecimalIntegerLiteral literals, like 08.
I think we can fix this later since it's an existing edge-case bug that isn't related to numeric separators and requires a non-trivial change.
This was referenced Aug 18, 2020
Closed
mdjermanovic
force-pushed
the
numeric-separators
branch
from
1c10aa7
to
785a7cc
Compare
btmills
approved these changes
Aug 28, 2020
| }, | ||
| { | ||
|
|
||
| // this would be indeed the same as `0x0_0`, but there's no need to autofix this edge case that looks more like a mistake. |
There was a problem hiding this comment.
Agreed that we don't need to handle this, and I appreciate that you noticed the edge case exists and added an explicit test for it 👍
1 task
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain:
refs #13568
Adds support for numeric separators (along with PR #13574).
What changes did you make? (Give an overview)
astUtils.isDecimalIntegerandisDecimalIntegerNumericToken. Also added tests for these helpers and some tests for rules that are using them.prefer-numeric-literalsandquote-propsrules.In total, this is one line of code + tests and comments.
Is there anything you'd like reviewers to focus on?
package.jsonshould be updated before merging.