Fix: handle parenthesized chaining expression in prefer-destructuring

[yeonjuan]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The current version, prefer-destructuring warns following cases.

• online demo

/* eslint prefer-destructuring: ["error", {
      "array": true,
      "object": true
    }, {
      "enforceForRenamedProperties": false
    }]*/

var bar = (object?.foo).bar; // Error
var bar = (object?.foo()).bar; // Error
var bar = (object?.foo?.()).bar; // Error
bar = (object?.foo).bar; // Error
bar = (object?.foo)[0]; // Error
bar = (object?.foo()).bar; // Error
bar = (object?.foo())[0]; // Error

But as described in this comment, it would occur TypeError when auto fixed.
This PR change "prefer-destructuring" to ignore those cases.

Is there anything you'd like reviewers to focus on?

[eslint-deprecated]

Hi @yeonjuan!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

• The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

[mdjermanovic]

I'm not sure if this is a bug, the fixed examples seem equivalent to their original versions. In particular, the original code would also throw a TypeError if object is nullish?

My concern in #13431 (comment) was that no-unsafe-optional-chaining should report both versions. Since we implemented that no-unsafe-optional-chaining reports var {bar} = object?.foo, the actual behavior of prefer-destructuring looks okay to me.

[yeonjuan]

@mdjermanovic Oh..Right. It was completely my misunderstanding I'll close this PR Thanks