Fix: no-useless-escape wrong loc and fix with CRLF in template elements #13953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment
What parser (default,
@babel/eslint-parser
,@typescript-eslint/parser
, etc.) are you using?default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
With CRLF linebreaks:
What did you expect to happen?
1 error with the location of
\
.Suggestions should remove
\
, or replace it with\\
.What actually happened? Please include the actual, raw output from ESLint.
Location is wrong, editor underlines space before
\
.Suggestion fixes are also wrong. The "remove" suggestion fixes the code to:
The "replace" suggestion fixes the code to:
What changes did you make? (Give an overview)
Replaced
node.value.raw
withsourceCode.getText(node)
for TemplateElement nodes.The rule assumed that
TemplateElement#value.raw
represents source code of the TemplateElement, similar toLiteral#raw
, but it's actually the Template Raw Value (TRV in the spec), the value that tag functions are getting as "raw".It's usually the same as the source code, but there's at least one difference: CR and CRLF are normalized to LF.
Is there anything you'd like reviewers to focus on?
The regex will now run on the full source code of strings and template elements, incl. quotes, backticks,
${
and}
. I think that slicing the inner content is unnecessary and probably less efficient.