docs: Add example with object pattern to computed-property-spacing

[whizzzkid]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

• Documentation update
• Bug fix (template)
• New rule (template)
• Changes an existing rule (template)
• Add autofixing to a rule
• Add a CLI option
• Add something to the core
• Other, please explain:

What changes did you make? (Give an overview)

I faced #14002 and added an example and wording to help others find it.

Is there anything you'd like reviewers to focus on?

the wording and the right place.

[eslint-deprecated]

Hi @whizzzkid!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

• The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

[btmills]

Thanks, documenting the destructuring case is helpful! I left an inline suggestion to fix a syntax error in the example, but this'll be good to go once that's fixed.

[btmills]

Parentheses are invalid syntax here:

Suggested change

	const ({ [a]: someProp } = obj); // someProp now maps to the value of prop.
	const { [a]: someProp } = obj; // someProp now maps to the value of prop.

[whizzzkid]

Wait, I think I did not read this right, that syntax looks wrong, that works, when assigning to a delcared variable:

let someProp;
({ [a]: someProp } = obj);

but if we are declaring a new variable:

const { [a]: someProp } = obj;

this is mentioned in this section: Assignment without declaration

[eslint-deprecated]

Hi @whizzzkid!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

[mdjermanovic]

I marked this as 'evaluating' for now since there's an issue related to this change #12048 and it isn't accepted yet.

I think it's most likely that we will accept this documentation update, at least for the computed-property-spacing rule, but we should also add some test cases to confirm this behavior. It can be a separate PR.

[eslint-github-bot]

Hi @whizzzkid!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

Read more about contributing to ESLint here

[mdjermanovic]

@whizzzkid sorry for the delay, this PR is now accepted.

const ({ [a]: someProp } = obj); is invalid syntax, If you are still interested in finishing this, I left a suggestion to fix the syntax and align the example with other examples.

[mdjermanovic]

Suggested change

	// applies to the spacing for dynamic keys (computed property key) when destructuring objects.
	const ({ [a]: someProp } = obj); // someProp now maps to the value of prop.
	var { [a]: x } = obj; // computed property key in object destructuring pattern (ECMAScript 6)

[linux-foundation-easycla]

• ❌ - Nishant Arora The commit (79e3bca) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[eslint-github-bot]

Hi @whizzzkid!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

[mdjermanovic]

Closing due to age.