New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Crash with esquery when using JSX (fixes #13639) #14072
Conversation
I think there is an error in the test that has nothing to do with my changes. Can I include a fix for the error in this PR? |
I think it might be fixed in #14067. |
Hi @ota-meshi, thanks for this PR, and thanks for working on estools/esquery#112!
We'll try to fix that as soon as possible, once we figure out what's the best course of action (probably #14067). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for doing all the work to make this possible, @ota-meshi!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, I left some questions about testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the great work!
Thanks for contributing! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #13639
What changes did you make? (Give an overview)
This PR uses a new option in esquery to solve the crash problem with non-standard ASTs such as JSX and some queries.
Is there anything you'd like reviewers to focus on?