New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: support absolute filename in preprocessor #14205
Conversation
Hi @JounQin!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
We intentionally don't allow absolute paths, because the processor can then return any path, while it must be a child file of the original file, as specified in the Specifying Processor user documentation:
The returned path also shouldn't contain any path separators (e.g., |
This limitation breaks rules which require file exist like typescript-eslint/typescript-eslint#3174 I was thinking to create a temporary file for I don't understand why it should be limited, what's the benif? |
|
OK, fair enough to me. Let's continue to discuss it on the original issue for getting real path. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
fix #11989 (comment)
Is there anything you'd like reviewers to focus on?