Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade eslint-plugin-jsdoc to v25 and remove --legacy-peer-deps #14244

Merged
merged 6 commits into from Mar 25, 2021
Merged

Chore: Upgrade eslint-plugin-jsdoc to v25 and remove --legacy-peer-deps #14244

merged 6 commits into from Mar 25, 2021

Commits on Mar 23, 2021

  1. Chore: Upgrade eslint-plugin-jsdoc to v25 

    This is a Chore instead of an Upgrade because it's in `devDependencies`.
v25 is the first release of `eslint-plugin-jsdoc` to bump the `eslint`
peer dependency to allow `eslint@7`. Once it's upgraded, we won't have
to use `--legacy-peer-deps` to install dependencies with npm v7. The
newer version was unsatisfied with the `cliOptions` param to
`translateOptions` typed as just `Object`, so I turned our Optionator
config into a JSDoc typedef.
    @btmills
    btmills committed Mar 23, 2021
    Copy the full SHA
    258eb49 View commit details
    Browse the repository at this point in the history

  2. Chore: npm v7 no longer needs --legacy-peer-deps (refs #13844) 

    `eslint-plugin-jsdoc` was the last upgrade needed to be compatible with
the new peer dependency resolution in npm v7.
    @btmills
    btmills committed Mar 23, 2021
    Copy the full SHA
    bfb6da4 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Docs: Make ParsedCLIOptions typedef name consistent 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @btmills @mdjermanovic
    btmills and mdjermanovic committed Mar 24, 2021
    Copy the full SHA
    ca53888 View commit details
    Browse the repository at this point in the history

  2. Docs: Properties with default values are non-optional 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @btmills @mdjermanovic
    btmills and mdjermanovic committed Mar 24, 2021
    Copy the full SHA
    9add528 View commit details
    Browse the repository at this point in the history

  3. Docs: Add _ filenames/patterns to ParsedCLIOptions typedef

    @btmills
    btmills committed Mar 24, 2021
    Copy the full SHA
    5333fbe View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Docs: ParsedCLIOptions.fixType is optional 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @btmills @mdjermanovic
    btmills and mdjermanovic committed Mar 25, 2021
    Copy the full SHA
    836ec79 View commit details
    Browse the repository at this point in the history