Chore: Upgrade mocha to 8.3.2 #14278
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Dev tooling update (Upgrades
mocha
to the latest version to fix deprecation warnings when runningnpm install
in the ESLint repo).What changes did you make? (Give an overview)
I upgraded mocha and mocha-junit-reporter to the latest versions.
Is there anything you'd like reviewers to focus on?
I believe we are not affected by any of Mocha's breaking changes in version 8, and the tests work on my machine, but I'd like a second look at that.
Mocha v8.0.0 release notes
A potential next step would be testing the new parallel tests feature in Mocha 8.