New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Drop codeframe
and table
formatters
#14316
Conversation
Easy upgrades FTW
ping @fregante — any progress? Would be cool to get this merged 😎 |
Sorry for the delay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fregante can you fix #14316 (comment), and rebase (there's a conflict in package.json
)?
Everything else LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see that the 8.0.0 milestone has been created, excited for that! Can we add this PR to the milestone as well? Thanks! |
Only issues are in v8.0.0 board. This PR is there by virtue of the linked issue. |
Ah of course. Sorry for the noise! |
If anyone wants to maintain these 2 formatters, let me know, they're available as standalone projects:
Please advertise them in your post because I won't be maintaining them. |
Fixes #14277
Related to #14098
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Removal of features. Breaking
What changes did you make? (Give an overview)
I dropped the
table
andcodeframe
formatters from the core as discussed in #14277Is there anything you'd like reviewers to focus on?