New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: upgrade espree and support new class features (refs #14343) #14591
Merged
Commits on Jul 23, 2021
-
-
- `getFunctionNameWithKind(node)` ... supports class fields and private identifier. And now it uses property names rather than function names if named function expressions are methods because the property name is exposed. - `getFunctionHeadLoc(node)` ... supports class fields. And now returns the range of property names instead of the arrow locations if arrow functions are at method places. - `isSameReference(l,r)` ... supports `PrivateIdentifier`.
-
This commit includes a large refactoring. Previously, the `Identifier` node listener handled all cases by checking parent node types. But because the `Identifier` node has so broad meanings, it's confusing about what kind of nodes it's handling. Now it uses variables and references of `eslint-scope`. And it checks properties, re-exported identifiers, and labels by detailed esqueries. The property check newly supports class fields and private identifiers. This fixes #13021 as well.
-
-
-
-
-
-
Function expressions at field initializers have inferred names. Therefore the `as-needed` option should not report anonymous functions at field initializers.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Jul 27, 2021
Commits on Jul 28, 2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.