Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Fixable disable directives (fixes #11815) #14617

Merged
merged 33 commits into from Aug 5, 2021
Merged

Breaking: Fixable disable directives (fixes #11815) #14617

merged 33 commits into from Aug 5, 2021

Commits on May 23, 2021

  1. New: Fixable disable directives

    Josh Goldberg committed May 23, 2021
    Copy the full SHA
    336f392 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Part of the way there: not ready yet

    Josh Goldberg committed Jun 22, 2021
    Copy the full SHA
    d0148c8 View commit details
    Browse the repository at this point in the history

  2. Generally fixed up, and just started on unit tests

    Josh Goldberg committed Jun 22, 2021
    Copy the full SHA
    bead8e8 View commit details
    Browse the repository at this point in the history

  3. lodash.flatMap

    Josh Goldberg committed Jun 22, 2021
    Copy the full SHA
    bd16fc8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fixable-disable-directives

    Josh Goldberg committed Jun 22, 2021
    Copy the full SHA
    104dd82 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master'

    Josh Goldberg committed Jun 22, 2021
    Copy the full SHA
    47723ee View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Progress...

    Josh Goldberg committed Jun 25, 2021
    Copy the full SHA
    34ce0a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Fixed the remaining pre-existing unit tests

    Josh Goldberg committed Jun 26, 2021
    Copy the full SHA
    ad043ff View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Fixed up some tests

    Josh Goldberg committed Jun 30, 2021
    Copy the full SHA
    0922789 View commit details
    Browse the repository at this point in the history

  2. unprocessedDirective.parentComment

    Josh Goldberg committed Jun 30, 2021
    Copy the full SHA
    187d396 View commit details
    Browse the repository at this point in the history

  3. Avoided rescan by passing commentToken in parentComment

    Josh Goldberg committed Jun 30, 2021
    Copy the full SHA
    89d15c8 View commit details
    Browse the repository at this point in the history

  4. A lil edge case

    Josh Goldberg committed Jun 30, 2021
    Copy the full SHA
    1412904 View commit details
    Browse the repository at this point in the history

  5. Fix directive grouping the other direction

    Josh Goldberg committed Jun 30, 2021
    Copy the full SHA
    4f69052 View commit details
    Browse the repository at this point in the history

  6. Incorrect state directive reference

    Josh Goldberg committed Jun 30, 2021
    Copy the full SHA
    03bfb8e View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Simplified parentComment / commentToken range

    Josh Goldberg committed Jul 14, 2021
    Copy the full SHA
    f60e0be View commit details
    Browse the repository at this point in the history

  2. Use Map in lib/linter/apply-disable-directives.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @JoshuaKGoldberg @mdjermanovic
    JoshuaKGoldberg and mdjermanovic committed Jul 14, 2021
    Copy the full SHA
    e834d3d View commit details
    Browse the repository at this point in the history

  3. Used suggestion for individual directives removal

    Josh Goldberg committed Jul 14, 2021
    Copy the full SHA
    df8267e View commit details
    Browse the repository at this point in the history

  4. Boolean in lib/cli-engine/cli-engine.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @JoshuaKGoldberg @mdjermanovic
    JoshuaKGoldberg and mdjermanovic committed Jul 14, 2021
    Copy the full SHA
    40fd954 View commit details
    Browse the repository at this point in the history

  5. Docs fixups

    Josh Goldberg committed Jul 14, 2021
    Copy the full SHA
    8808b4f View commit details
    Browse the repository at this point in the history

  6. Added tests

    Josh Goldberg committed Jul 14, 2021
    Copy the full SHA
    195d76b View commit details
    Browse the repository at this point in the history

  7. Tests and fix for multiple rule lists

    Josh Goldberg committed Jul 14, 2021
    Copy the full SHA
    eb4ddec View commit details
    Browse the repository at this point in the history

  8. Remove unused sourceCode from tests

    Josh Goldberg committed Jul 14, 2021
    Copy the full SHA
    4d98acb View commit details
    Browse the repository at this point in the history

  9. Added high-level test in linter.js

    Josh Goldberg committed Jul 14, 2021
    Copy the full SHA
    597949f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
    @JoshuaKGoldberg @btmills
    JoshuaKGoldberg and btmills committed Jul 17, 2021
    Copy the full SHA
    66e016c View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @JoshuaKGoldberg @mdjermanovic
    JoshuaKGoldberg and mdjermanovic committed Jul 30, 2021
    Copy the full SHA
    a3228b6 View commit details
    Browse the repository at this point in the history

  2. Added require

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 30, 2021
    Copy the full SHA
    0459541 View commit details
    Browse the repository at this point in the history

  3. Wrong order...

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 30, 2021
    Copy the full SHA
    b540171 View commit details
    Browse the repository at this point in the history

  4. Also mention in command-line-interface.md

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 30, 2021
    Copy the full SHA
    c760631 View commit details
    Browse the repository at this point in the history

  5. Respect disableFixes (not yet tested)

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 30, 2021
    Copy the full SHA
    a638521 View commit details
    Browse the repository at this point in the history

  6. Fixed up existing tests

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 30, 2021
    Copy the full SHA
    7e3ae49 View commit details
    Browse the repository at this point in the history

  7. Add unit test for options.disableFixes

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 30, 2021
    Copy the full SHA
    6edce5e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master'

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 30, 2021
    Copy the full SHA
    f17d501 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @JoshuaKGoldberg @mdjermanovic
    JoshuaKGoldberg and mdjermanovic committed Jul 31, 2021
    Copy the full SHA
    804d101 View commit details
    Browse the repository at this point in the history