Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Add no-unused-private-class-members rule (fixes #14859) #14895

Merged
merged 12 commits into from Oct 22, 2021
Merged

New: Add no-unused-private-class-members rule (fixes #14859) #14895

merged 12 commits into from Oct 22, 2021

Commits on Aug 6, 2021

  1. New: Report unused private class members (fixes eslint#14859) 

    For any private class property or method, report those that are
unused. Since private class members can only be accessed in the
same class body, we can safely assume that all usages are processed
when we leave the ClassBody scope.
    @TimvdLippe
    TimvdLippe committed Aug 6, 2021
    Copy the full SHA
    8b2d49f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Handle all edge cases per feedback 

    Also remove the rule from recommended for now, as that is a breaking
change.
    @TimvdLippe
    TimvdLippe committed Oct 1, 2021
    Copy the full SHA
    4c9f57a View commit details
    Browse the repository at this point in the history

  2. Remove duplication in assignment checking

    @TimvdLippe
    TimvdLippe committed Oct 1, 2021
    Copy the full SHA
    d253c4e View commit details
    Browse the repository at this point in the history

  3. Optimize check for property deletion 

    This also removes the usage of optional chaining, which isn't
supported yet on Node environments that ESLint supports.
    @TimvdLippe
    TimvdLippe committed Oct 1, 2021
    Copy the full SHA
    1853675 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Use more descriptive names

    @TimvdLippe
    TimvdLippe committed Oct 4, 2021
    Copy the full SHA
    71d7a9b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into no-unused-private-class-members

    @TimvdLippe
    TimvdLippe committed Oct 4, 2021
    Copy the full SHA
    72e1102 View commit details
    Browse the repository at this point in the history

  3. Handle more edge cases

    @TimvdLippe
    TimvdLippe committed Oct 4, 2021
    Copy the full SHA
    6dd7404 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @TimvdLippe @mdjermanovic
    TimvdLippe and mdjermanovic committed Oct 14, 2021
    Copy the full SHA
    855484b View commit details
    Browse the repository at this point in the history

  2. Update lib/rules/no-unused-private-class-members.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @TimvdLippe @mdjermanovic
    TimvdLippe and mdjermanovic committed Oct 14, 2021
    Copy the full SHA
    5b6b934 View commit details
    Browse the repository at this point in the history

  3. Update no-unused-private-class-members.js

    @TimvdLippe
    TimvdLippe committed Oct 14, 2021
    Copy the full SHA
    273cbf6 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Merge branch 'main' into no-unused-private-class-members

    @TimvdLippe
    TimvdLippe committed Oct 21, 2021
    Copy the full SHA
    73dbc7f View commit details
    Browse the repository at this point in the history

  2. Fix accessor handling

    @TimvdLippe
    TimvdLippe committed Oct 21, 2021
    Copy the full SHA
    5433a35 View commit details
    Browse the repository at this point in the history