Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: fix no-unused-vars false negative with comma operator #14928

Merged
merged 2 commits into from Aug 21, 2021
Merged

Update: fix no-unused-vars false negative with comma operator #14928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3280fa3
Update: fix no-unused-vars false negative with comma operator
ersachin3112 Aug 14, 2021
3f662e7
Fix: no-unused-vars false positive
ersachin3112 Aug 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 26 additions & 27 deletions lib/rules/no-unused-vars.js
View file
Open in desktop
Expand Up @@ -295,6 +295,31 @@ module.exports = {
);
}

/**
* Checks whether a given node is unused expression or not.
* @param {ASTNode} node The node itself
* @returns {boolean} The node is an unused expression.
* @private
*/
function isUnusedExpression(node) {
const parent = node.parent;

if (parent.type === "ExpressionStatement") {
return true;
}

if (parent.type === "SequenceExpression") {
const isLastExpression = parent.expressions[parent.expressions.length - 1] === node;

if (!isLastExpression) {
return true;
}
return isUnusedExpression(parent);
}

return false;
}

/**
* If a given reference is left-hand side of an assignment, this gets
* the right-hand side node of the assignment.
Expand All @@ -313,7 +338,6 @@ module.exports = {
function getRhsNode(ref, prevRhsNode) {
const id = ref.identifier;
const parent = id.parent;
const grandparent = parent.parent;
const refScope = ref.from.variableScope;
const varScope = ref.resolved.scope.variableScope;
const canBeUsedLater = refScope !== varScope || astUtils.isInLoop(id);
Expand All @@ -327,7 +351,7 @@ module.exports = {
}

if (parent.type === "AssignmentExpression" &&
grandparent.type === "ExpressionStatement" &&
isUnusedExpression(parent) &&
id === parent.left &&
!canBeUsedLater
) {
Expand Down Expand Up @@ -410,31 +434,6 @@ module.exports = {
);
}

/**
* Checks whether a given node is unused expression or not.
* @param {ASTNode} node The node itself
* @returns {boolean} The node is an unused expression.
* @private
*/
function isUnusedExpression(node) {
const parent = node.parent;

if (parent.type === "ExpressionStatement") {
return true;
}

if (parent.type === "SequenceExpression") {
const isLastExpression = parent.expressions[parent.expressions.length - 1] === node;

if (!isLastExpression) {
return true;
}
return isUnusedExpression(parent);
}

return false;
}

/**
* Checks whether a given reference is a read to update itself or not.
* @param {eslint-scope.Reference} ref A reference to check.
Expand Down
50 changes: 50 additions & 0 deletions tests/lib/rules/no-unused-vars.js
View file
Open in desktop
Expand Up @@ -180,6 +180,7 @@ ruleTester.run("no-unused-vars", rule, {
// Sequence Expressions (See https://github.com/eslint/eslint/issues/14325)
{ code: "let x = 0; foo = (0, x++);", parserOptions: { ecmaVersion: 6 } },
{ code: "let x = 0; foo = (0, x += 1);", parserOptions: { ecmaVersion: 6 } },
{ code: "let x = 0; foo = (0, x = x + 1);", parserOptions: { ecmaVersion: 6 } },

// caughtErrors
{
Expand Down Expand Up @@ -1064,6 +1065,55 @@ ruleTester.run("no-unused-vars", rule, {
parserOptions: { ecmaVersion: 2015 },
errors: [{ ...assignedError("x"), line: 1, column: 23 }]
},

// https://github.com/eslint/eslint/issues/14866
{
code: `let z = 0;
z = z + 1, z = 2;
`,
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("z"), line: 2, column: 24 }]
},
snitin315 marked this conversation as resolved.
Show resolved Hide resolved
{
code: `let z = 0;
z = z+1, z = 2;
z = 3;`,
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("z"), line: 3, column: 13 }]
},
{
code: `let z = 0;
z = z+1, z = 2;
z = z+3;
`,
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("z"), line: 3, column: 13 }]
},
{
code: "let x = 0; 0, x = x+1;",
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("x"), line: 1, column: 15 }]
},
{
code: "let x = 0; x = x+1, 0;",
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("x"), line: 1, column: 12 }]
},
{
code: "let x = 0; foo = ((0, x = x + 1), 0);",
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("x"), line: 1, column: 23 }]
},
{
code: "let x = 0; foo = (x = x+1, 0);",
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("x"), line: 1, column: 19 }]
},
{
code: "let x = 0; 0, (1, x=x+1);",
parserOptions: { ecmaVersion: 2020 },
errors: [{ ...assignedError("x"), line: 1, column: 19 }]
},
{
code: "(function ({ a, b }, { c } ) { return b; })();",
parserOptions: { ecmaVersion: 2015 },
Expand Down