Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Refactor comments of tests #14956

Merged
merged 1 commit into from Aug 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/_utils/in-memory-fs.js
Expand Up @@ -4,9 +4,17 @@
*/
"use strict";

//-----------------------------------------------------------------------------
// Requirements
//-----------------------------------------------------------------------------

const path = require("path");
const { Volume, createFsFromVolume } = require("memfs");

//-----------------------------------------------------------------------------
// Helpers
//-----------------------------------------------------------------------------

/**
* Define in-memory file system.
* @param {Object} options The options.
Expand Down Expand Up @@ -52,6 +60,10 @@ function defineInMemoryFs({
return fs;
}

//-----------------------------------------------------------------------------
// Exports
//-----------------------------------------------------------------------------

module.exports = {
defineInMemoryFs
};
16 changes: 16 additions & 0 deletions tests/bin/eslint.js
Expand Up @@ -5,13 +5,25 @@

"use strict";

//-----------------------------------------------------------------------------
// Requirements
//-----------------------------------------------------------------------------

const childProcess = require("child_process");
const fs = require("fs");
const assert = require("chai").assert;
const path = require("path");

//------------------------------------------------------------------------------
// Data
//------------------------------------------------------------------------------

const EXECUTABLE_PATH = path.resolve(path.join(__dirname, "../../bin/eslint.js"));

//-----------------------------------------------------------------------------
// Helpers
//-----------------------------------------------------------------------------

/**
* Returns a Promise for when a child process exits
* @param {ChildProcess} exitingProcess The child process
Expand Down Expand Up @@ -48,6 +60,10 @@ function getOutput(runningProcess) {
return awaitExit(runningProcess).then(() => ({ stdout, stderr }));
}

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("bin/eslint.js", () => {
const forkedProcesses = new Set();

Expand Down
4 changes: 4 additions & 0 deletions tests/conf/eslint-all.js
Expand Up @@ -13,6 +13,10 @@ const assert = require("chai").assert;
const eslintAll = require("../../conf/eslint-all");
const rules = eslintAll.rules;

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("eslint-all", () => {
it("should only include rules", () => {
const ruleNames = Object.keys(rules);
Expand Down
4 changes: 4 additions & 0 deletions tests/conf/eslint-recommended.js
Expand Up @@ -13,6 +13,10 @@ const assert = require("chai").assert;
const eslintRecommended = require("../../conf/eslint-recommended");
const rules = eslintRecommended.rules;

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("eslint-recommended", () => {
it("should configure recommended rules as error", () => {
assert.strictEqual(rules["no-undef"], "error");
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/cli-engine/file-enumerator.js
Expand Up @@ -4,6 +4,10 @@
*/
"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const fs = require("fs");
const path = require("path");
const os = require("os");
Expand All @@ -17,6 +21,10 @@ const {
const { createCustomTeardown } = require("../../_utils");
const { FileEnumerator } = require("../../../lib/cli-engine/file-enumerator");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("FileEnumerator", () => {
describe("'iterateFiles(patterns)' method should iterate files and configs.", () => {
describe("with three directories ('lib', 'lib/nested', 'test') that contains 'one.js' and 'two.js'", () => {
Expand Down
4 changes: 4 additions & 0 deletions tests/lib/cli-engine/formatters/stylish.js
Expand Up @@ -14,6 +14,10 @@ const assert = require("chai").assert,
proxyquire = require("proxyquire"),
sinon = require("sinon");

//-----------------------------------------------------------------------------
// Helpers
//-----------------------------------------------------------------------------

/*
* Chalk protects its methods so we need to inherit from it
* for Sinon to work.
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/cli-engine/load-rules.js
Expand Up @@ -5,9 +5,17 @@

"use strict";

//-----------------------------------------------------------------------------
// Requirements
//-----------------------------------------------------------------------------

const assert = require("chai").assert;
const loadRules = require("../../../lib/cli-engine/load-rules");

//-----------------------------------------------------------------------------
// Tests
//-----------------------------------------------------------------------------

describe("when given an invalid rules directory", () => {
it("should throw an error", () => {
assert.throws(() => {
Expand Down
12 changes: 12 additions & 0 deletions tests/lib/linter/apply-disable-directives.js
Expand Up @@ -5,9 +5,17 @@

"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const assert = require("chai").assert;
const applyDisableDirectives = require("../../../lib/linter/apply-disable-directives");

//-----------------------------------------------------------------------------
// Helpers
//-----------------------------------------------------------------------------

/**
* Creates a ParentComment for a given range.
* @param {[number, number]} range total range of the comment
Expand All @@ -22,6 +30,10 @@ function createParentComment(range, value, ruleIds = []) {
};
}

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("apply-disable-directives", () => {
describe("/* eslint-disable */ comments without rules", () => {
it("keeps problems before the comment on the same line", () => {
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/linter/interpolate.js
@@ -1,8 +1,16 @@
"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const assert = require("chai").assert;
const interpolate = require("../../../lib/linter/interpolate");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("interpolate()", () => {
it("passes through text without {{ }}", () => {
const message = "This is a very important message!";
Expand Down
7 changes: 6 additions & 1 deletion tests/lib/linter/node-event-generator.js
Expand Up @@ -17,8 +17,9 @@ const assert = require("assert"),
createEmitter = require("../../../lib/linter/safe-emitter"),
NodeEventGenerator = require("../../../lib/linter/node-event-generator");


//------------------------------------------------------------------------------
// Tests
// Constants
//------------------------------------------------------------------------------

const ESPREE_CONFIG = {
Expand All @@ -31,6 +32,10 @@ const ESPREE_CONFIG = {

const STANDARD_ESQUERY_OPTION = { visitorKeys: vk.KEYS, fallback: Traverser.getKeys };

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("NodeEventGenerator", () => {
EventGeneratorTester.testEventGeneratorInterface(
new NodeEventGenerator(createEmitter(), STANDARD_ESQUERY_OPTION)
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/linter/safe-emitter.js
Expand Up @@ -5,9 +5,17 @@

"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const createEmitter = require("../../../lib/linter/safe-emitter");
const assert = require("chai").assert;

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("safe-emitter", () => {
describe("emit() and on()", () => {
it("allows listeners to be registered calls them when emitted", () => {
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/linter/timing.js
@@ -1,8 +1,16 @@
"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const { getListSize } = require("../../../lib/linter/timing");
const assert = require("chai").assert;

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

describe("timing", () => {
describe("getListSize()", () => {
after(() => {
Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/array-callback-return.js
Expand Up @@ -12,6 +12,10 @@
const rule = require("../../../lib/rules/array-callback-return"),
{ RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();

const allowImplicitOptions = [{ allowImplicit: true }];
Expand Down
1 change: 1 addition & 0 deletions tests/lib/rules/arrow-parens.js
Expand Up @@ -18,6 +18,7 @@ const parser = baseParser.bind(null, "arrow-parens");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });

const valid = [
Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/complexity.js
Expand Up @@ -48,6 +48,10 @@ function makeError(name, complexity, max) {
};
}

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2021 } });

ruleTester.run("complexity", rule, {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/curly.js
Expand Up @@ -13,7 +13,7 @@ const rule = require("../../../lib/rules/curly"),
{ RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Helpers
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/rules/default-param-last.js
Expand Up @@ -4,9 +4,17 @@
*/
"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const rule = require("../../../lib/rules/default-param-last");
const { RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const SHOULD_BE_LAST = "shouldBeLast";

const ruleTester = new RuleTester({
Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/dot-notation.js
Expand Up @@ -28,6 +28,10 @@ function q(str) {
return `"${str}"`;
}

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

ruleTester.run("dot-notation", rule, {
valid: [
"a.b;",
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/for-direction.js
Expand Up @@ -13,7 +13,7 @@ const rule = require("../../../lib/rules/for-direction");
const { RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Helpers
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();
Expand Down
1 change: 1 addition & 0 deletions tests/lib/rules/global-require.js
Expand Up @@ -15,6 +15,7 @@ const rule = require("../../../lib/rules/global-require"),
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();

const valid = [
Expand Down
6 changes: 5 additions & 1 deletion tests/lib/rules/indent.js
Expand Up @@ -15,7 +15,7 @@ const fs = require("fs");
const path = require("path");

//------------------------------------------------------------------------------
// Tests
// Helpers
//------------------------------------------------------------------------------

const fixture = fs.readFileSync(path.join(__dirname, "../../fixtures/rules/indent/indent-invalid-fixture-1.js"), "utf8");
Expand Down Expand Up @@ -56,6 +56,10 @@ function expectedErrors(providedIndentType, providedErrors) {
}));
}

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 8, ecmaFeatures: { jsx: true } } });

ruleTester.run("indent", rule, {
Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/init-declarations.js
Expand Up @@ -12,6 +12,10 @@
const rule = require("../../../lib/rules/init-declarations"),
{ RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();

ruleTester.run("init-declarations", rule, {
Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/jsx-quotes.js
Expand Up @@ -12,6 +12,10 @@
const rule = require("../../../lib/rules/jsx-quotes"),
{ RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6, ecmaFeatures: { jsx: true } } });

ruleTester.run("jsx-quotes", rule, {
Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/key-spacing.js
Expand Up @@ -12,6 +12,10 @@
const rule = require("../../../lib/rules/key-spacing"),
{ RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();

ruleTester.run("key-spacing", rule, {
Expand Down
1 change: 1 addition & 0 deletions tests/lib/rules/lines-between-class-members.js
Expand Up @@ -15,6 +15,7 @@ const { RuleTester } = require("../../../lib/rule-tester");
//------------------------------------------------------------------------------
// Helpers
//------------------------------------------------------------------------------

const alwaysError = { messageId: "always" };
const neverError = { messageId: "never" };

Expand Down
1 change: 1 addition & 0 deletions tests/lib/rules/max-lines-per-function.js
Expand Up @@ -7,6 +7,7 @@
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const rule = require("../../../lib/rules/max-lines-per-function");
const { RuleTester } = require("../../../lib/rule-tester");

Expand Down