New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Normalize ecmaVersion to eslint-scope when using custom parser #15268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
What happens when the ecmaVersion is unset? |
Analyze the scope as ES5 as before. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Add something to the core
Fixes #15256
What changes did you make? (Give an overview)
Change to pass 6 to eslint-scope when ecmaVersion is non number.
This allows the scope to be analyzed as ES6 if the user uses a custom parser and
ecmaVersion: latest
.Is there anything you'd like reviewers to focus on?