Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update CLA information #15630

Merged
merged 4 commits into from Feb 25, 2022
Merged

docs: update CLA information #15630

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80d669f
docs: udpate CLA information
snitin315 Feb 22, 2022
3aa73f6
docs: update CLA info
snitin315 Feb 25, 2022
3ff32af
docs: suggestion
snitin315 Feb 25, 2022
05e66e6
Update docs/developer-guide/contributing/README.md
nzakas Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/developer-guide/contributing/pull-requests.md
View file
Open in desktop
Expand Up @@ -6,7 +6,6 @@ If you want to contribute to an ESLint repo, please use a GitHub pull request. T

If you'd like to work on a pull request and you've never submitted code before, follow these steps:

1. Sign our [Contributor License Agreement](https://cla.js.foundation/eslint/eslint).
1. Set up a [development environment](../development-environment.md).
1. If you want to implement a breaking change or a change to the core, ensure there's an issue that describes what you're doing and the issue has been accepted. You can create a new issue or just indicate you're [working on an existing issue](working-on-issues.md). Bug fixes, documentation changes, and other pull requests do not require an issue.

Expand Down Expand Up @@ -137,6 +136,8 @@ git push -f origin issue1234

Now you're ready to send the pull request. Go to your ESLint fork and then follow the [GitHub documentation](https://help.github.com/articles/creating-a-pull-request) on how to send a pull request.

In order to submit code or documentation to an ESLint project, you’ll be asked to sign our CLA when you send your first pull request. (Read more about the Open JS Foundation CLA process at <https://cla.openjsf.org/>.)

## Following Up

Once your pull request is sent, it's time for the team to review it. As such, please make sure to:
Expand Down