Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no-underscore-dangle in private and public class fields from es2022 #15811

Conversation

robertotcestari
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This fixes and closes #15810

Is there anything you'd like reviewers to focus on?

Maybe an extra option should be available (for example, enforceInPropertyNames), as we currently only have enforceInMethodName.

@eslint-github-bot eslint-github-bot bot added triage An ESLint team member will look at this issue soon bug ESLint is working incorrectly labels Apr 26, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 26, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: robertotcestari / name: Roberto Cestari (676bb77)

@robertotcestari robertotcestari changed the title fix: add support for private and public class fields from es2022 fix: no-underscore-dangle in private and public class fields from es2022 Apr 26, 2022
@robertotcestari
Copy link
Contributor Author

Closing in favor of #15818 .
The new PR adds a new option in the rule no-underscore-dangle as per discussion on #15810

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 26, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: no-underscore-dangle not working as expected in ES2022 public/private class fields
1 participant