docs: align footer-tablet view #15918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
triage
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
snitin315
reviewed
May 25, 2022
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| @media all and (max-width: 800px) { | |||
| padding: 1.5rem 0 4rem; | |||
| align-items:center ; | |||
There was a problem hiding this comment.
Suggested change
| align-items:center ; | |
| align-items: center; |
snitin315
added
accepted
snitin315
approved these changes
May 25, 2022
btmills
approved these changes
Jun 1, 2022
btmills
reviewed
Jun 1, 2022
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| @media all and (max-width: 800px) { | |||
There was a problem hiding this comment.
Try setting your view width to exactly 800px. It'll give a combination of the tablet and desktop views:
That's because there's a min-width: 800px media query that makes .docs-content a grid.
Currently, the footer is centered at widths <= 800px, and the page is a grid at >= 800px, so there's a bit of overlap. If we make this a max-width of 799px, that overlap goes away:
Suggested change
| @media all and (max-width: 800px) { | |
| @media all and (max-width: 799px) { |
mdjermanovic
reviewed
Jun 1, 2022
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| @media all and (max-width: 800px) { | |||
| padding: 1.5rem 0 4rem; | |||
| align-items: center; | |||
There was a problem hiding this comment.
I think this is included in #15944
|
Closing this PR in favor of #15944 |
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
Changed the footer alignment in docs for tablet view.
Before :
After :