Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix npm run perf crashes #16258

Merged
merged 3 commits into from Aug 31, 2022
Merged

chore: fix npm run perf crashes #16258

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4e9c05
chore: fix `npm run perf` crashes
aladdin-add Aug 29, 2022
48eb7ec
fix: windows compat
aladdin-add Aug 30, 2022
89d1e91
Update Makefile.js
aladdin-add Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 13 additions & 11 deletions Makefile.js
View file
Open in desktop
Expand Up @@ -76,7 +76,7 @@ const NODE = "node ", // intentional extra space
MARKDOWNLINT_IGNORE_INSTANCE = ignore().add(fs.readFileSync(path.join(__dirname, ".markdownlintignore"), "utf-8")),
MARKDOWN_FILES_ARRAY = MARKDOWNLINT_IGNORE_INSTANCE.filter(find("docs/").concat(ls(".")).filter(fileType("md"))),
TEST_FILES = "\"tests/{bin,conf,lib,tools}/**/*.js\"",
PERF_ESLINTRC = path.join(PERF_TMP_DIR, "eslintrc.yml"),
PERF_ESLINTRC = path.join(PERF_TMP_DIR, "eslint.config.js"),
PERF_MULTIFILES_TARGET_DIR = path.join(PERF_TMP_DIR, "eslint"),
PERF_MULTIFILES_TARGETS = `"${PERF_MULTIFILES_TARGET_DIR + path.sep}{lib,tests${path.sep}lib}${path.sep}**${path.sep}*.js"`,

Expand Down Expand Up @@ -911,19 +911,21 @@ function downloadMultifilesTestTarget(cb) {
* @returns {void}
*/
function createConfigForPerformanceTest() {
const content = [
"root: true",
"env:",
" node: true",
" es6: true",
"rules:"
];
let rules = "";

for (const [ruleId] of builtinRules) {
content.push(` ${ruleId}: 1`);
rules += (` "${ruleId}": 1,\n`);
}

content.join("\n").to(PERF_ESLINTRC);
const content = `
module.exports = [{
"languageOptions": {sourceType: "commonjs"},
"rules": {
${rules}
}
}];`;

content.to(PERF_ESLINTRC);
}

/**
Expand Down Expand Up @@ -983,7 +985,7 @@ function time(cmd, runs, runNumber, results, cb) {
function runPerformanceTest(title, targets, multiplier, cb) {
const cpuSpeed = os.cpus()[0].speed,
max = multiplier / cpuSpeed,
cmd = `${ESLINT}--config "${PERF_ESLINTRC}" --no-eslintrc --no-ignore ${targets}`;
cmd = `${ESLINT}--config "${PERF_ESLINTRC}" --no-config-lookup --no-ignore ${targets}`;

echo("");
echo(title);
Expand Down