Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: account for sourceType: "commonjs" in the strict rule #16308

Merged
merged 1 commit into from Sep 16, 2022
Merged

feat: account for sourceType: "commonjs" in the strict rule #16308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/strict.js
View file
Open in desktop
Expand Up @@ -105,7 +105,7 @@ module.exports = {
if (ecmaFeatures.impliedStrict) {
mode = "implied";
} else if (mode === "safe") {
mode = ecmaFeatures.globalReturn ? "global" : "function";
mode = ecmaFeatures.globalReturn || context.languageOptions.sourceType === "commonjs" ? "global" : "function";
}

/**
Expand Down
46 changes: 45 additions & 1 deletion tests/lib/rules/strict.js
View file
Open in desktop
Expand Up @@ -10,7 +10,8 @@
//------------------------------------------------------------------------------

const rule = require("../../../lib/rules/strict"),
{ RuleTester } = require("../../../lib/rule-tester");
{ RuleTester } = require("../../../lib/rule-tester"),
FlatRuleTester = require("../../../lib/rule-tester/flat-rule-tester");

//------------------------------------------------------------------------------
// Tests
Expand Down Expand Up @@ -659,3 +660,46 @@ ruleTester.run("strict", rule, {
}
]
});

const flatRuleTester = new FlatRuleTester();

// TODO: merge these tests into `ruleTester.run` once we switch to FlatRuleTester (when FlatRuleTester becomes RuleTester).
flatRuleTester.run("strict", rule, {
valid: [
{
code: "'use strict'; module.exports = function identity (value) { return value; }",
languageOptions: {
sourceType: "commonjs"
}
},
{
code: "'use strict'; module.exports = function identity (value) { return value; }",
options: ["safe"],
languageOptions: {
sourceType: "commonjs"
}
}
],

invalid: [
{
code: "module.exports = function identity (value) { return value; }",
options: ["safe"],
languageOptions: {
sourceType: "commonjs"
},
errors: [
{ messageId: "global", line: 1 }
]
},
{
code: "module.exports = function identity (value) { return value; }",
languageOptions: {
sourceType: "commonjs"
},
errors: [
{ messageId: "global", line: 1 }
]
}
]
});