New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove support for ignore files in FlatESLint #16355
Changes from all commits
f689141
89a13b1
8504abc
92ca045
1904f9a
2f9e14a
ebaec07
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,6 +78,23 @@ function createInternalFilesPatterns(pattern = null) { | |
|
||
module.exports = [ | ||
...compat.extends("eslint"), | ||
{ | ||
ignores: [ | ||
"build/**", | ||
"coverage/**", | ||
"docs/**", | ||
"!docs/.eleventy.js", | ||
"jsdoc/**", | ||
"templates/**", | ||
"tests/bench/**", | ||
"tests/fixtures/**", | ||
"tests/performance/**", | ||
"tmp/**", | ||
"tools/internal-rules/node_modules/**", | ||
"**/test.js", | ||
"!**/.eslintrc.js" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just double-checking: this still doesn't unignore There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct. When doing a glob search with a pattern that doesn't have an explicit dot that matches leading dots in file names, On the other hand, when directly using our config array to evaluate whether or not Overall, this line currently does not affect anything, but it may when we fix #16265 so I've left it in for now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That’s what I figured. 👍 |
||
] | ||
}, | ||
{ | ||
plugins: { | ||
"internal-rules": internalPlugin, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = [{ | ||
ignores: ["**/fixtures/**"] | ||
}]; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
const eslintConfig = require("./eslint.config.js"); | ||
|
||
module.exports = [ | ||
eslintConfig, | ||
{ | ||
ignores: ["**/*.json", "**/*.js"] | ||
} | ||
]; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
const eslintConfig = require("./eslint.config.js"); | ||
|
||
module.exports = [ | ||
eslintConfig, | ||
{ | ||
ignores: ["**/undef.js", "undef2.js", "**/undef3.js"] | ||
} | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this to be how we expect ignore patterns to work, but it would work the same without this change because of #16354.