Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use "ci" for Dependabot commit message #16377

Merged
merged 1 commit into from Oct 4, 2022
Merged

chore: use "ci" for Dependabot commit message #16377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Expand Up @@ -4,3 +4,5 @@ updates:
directory: "/"
schedule:
interval: "weekly"
commit-message:
prefix: "ci"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dependency changes should belong to chore, aka current value. ci should refer to changes to CI configuration (like this PR), not modifications made by CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I see depandabot PRs for github-actions only. I suppose this is because we don't have a lockfile.

Copy link
Member

@kecrily kecrily Oct 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can try renovate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are exploring it - #15726

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @kecrily. “ci” doesn’t seem appropriate for this type of change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://eslint.org/docs/latest/developer-guide/contributing/pull-requests ci - changes to our CI configuration files and scripts..
The dependabot updates to GitHub Actions, are only to CI scripts in the .github/workflows folder. If Dependabot is later used for other types of updates like NPM, the default of chore would still be used, even with this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah fair point! I didn't realize this was scoped to just GitHub Actions. In that case, I agree that ci makes sense. 👍