Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that directories can be unignored. #16436

Merged
merged 1 commit into from Oct 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -56,7 +56,7 @@
"bugs": "https://github.com/eslint/eslint/issues/",
"dependencies": {
"@eslint/eslintrc": "^1.3.3",
"@humanwhocodes/config-array": "^0.11.3",
"@humanwhocodes/config-array": "^0.11.5",
"@humanwhocodes/module-importer": "^1.0.1",
"@nodelib/fs.walk": "^1.2.8",
"ajv": "^6.10.0",
Expand Down
3 changes: 3 additions & 0 deletions tests/fixtures/ignores-subdirectory/eslint.config.js
@@ -0,0 +1,3 @@
module.exports = {
ignores: ["subdir"]
};
Empty file.
30 changes: 29 additions & 1 deletion tests/lib/eslint/flat-eslint.js
Expand Up @@ -1102,7 +1102,7 @@ describe("FlatESLint", () => {
});

// https://github.com/eslint/eslint/issues/16354
it("should skip subdirectory files when ignore pattern matches subdirectory", async () => {
it("should skip subdirectory files when ignore pattern matches deep subdirectory", async () => {
eslint = new FlatESLint({
cwd: getFixturePath("ignores-directory")
});
Expand All @@ -1124,6 +1124,34 @@ describe("FlatESLint", () => {

});

// https://github.com/eslint/eslint/issues/16414
it("should skip subdirectory files when ignore pattern matches subdirectory", async () => {
eslint = new FlatESLint({
cwd: getFixturePath("ignores-subdirectory")
});

await assert.rejects(async () => {
await eslint.lintFiles(["subdir/**/*.js"]);
}, /All files matched by 'subdir\/\*\*\/\*\.js' are ignored\./u);

const results = await eslint.lintFiles(["subdir/subsubdir/a.js"]);

assert.strictEqual(results.length, 1);
assert.strictEqual(results[0].filePath, getFixturePath("ignores-subdirectory/subdir/subsubdir/a.js"));
assert.strictEqual(results[0].warningCount, 1);
assert(results[0].messages[0].message.startsWith("File ignored"), "Should contain file ignored warning");

eslint = new FlatESLint({
cwd: getFixturePath("ignores-subdirectory/subdir")
});

await assert.rejects(async () => {
await eslint.lintFiles(["subsubdir/**/*.js"]);
}, /All files matched by 'subsubdir\/\*\*\/\*\.js' are ignored\./u);


});

// https://github.com/eslint/eslint/issues/16340
it("should lint files even when cwd directory name matches ignores pattern", async () => {
eslint = new FlatESLint({
Expand Down