Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle files with unspecified path in getRulesMetaForResults #16437

Merged
merged 4 commits into from Oct 31, 2022
Merged

fix: handle files with unspecified path in getRulesMetaForResults #16437

merged 4 commits into from Oct 31, 2022

Commits on Oct 20, 2022

  1. fix: handle files with unspecified path in getRulesMetaForResults 

    * In `getRulesMetaForResults`, files with an unspecified path are now treated as if they were located inside `cwd`.
* In `getRulesMetaForResults`, when a result referencing a rule has no config, we will explicitly throw an error with a descriptive message.
* Added top-level, internal functions `getPlaceholderPath` and `createExtraneousResultsError` to avoid code repetition.
* Added two new unit tests.
* Renamed an existing unit test to better disambiguate it from a new one. Also changed the assertion to check both error message and constructor.

Fixes #16410
    @fasttime
    fasttime committed Oct 20, 2022
    Copy the full SHA
    cf2c5a8 View commit details
    Browse the repository at this point in the history

  2. Add a new unit test, move around an existing one

    @fasttime
    fasttime committed Oct 20, 2022
    Copy the full SHA
    b756fda View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Add a unit test with linted and ignored files

    @fasttime
    fasttime committed Oct 24, 2022
    Copy the full SHA
    31d8e86 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Assert that there is an ignored file

    @fasttime
    fasttime committed Oct 29, 2022
    Copy the full SHA
    90b7df2 View commit details
    Browse the repository at this point in the history