Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make getRulesMetaForResults return a plain object in trivial case #16438

Merged
merged 1 commit into from Oct 18, 2022
Merged

fix: make getRulesMetaForResults return a plain object in trivial case #16438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/eslint/flat-eslint.js
View file
Open in desktop
Expand Up @@ -665,13 +665,12 @@ class FlatESLint {
*/
getRulesMetaForResults(results) {

const resultRules = new Map();

// short-circuit simple case
if (results.length === 0) {
return resultRules;
return {};
}

const resultRules = new Map();
const { configs } = privateMembers.get(this);

/*
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/eslint/eslint.js
View file
Open in desktop
Expand Up @@ -4971,7 +4971,7 @@ describe("ESLint", () => {

const rulesMeta = engine.getRulesMetaForResults([]);

assert.strictEqual(Object.keys(rulesMeta).length, 0);
assert.deepStrictEqual(rulesMeta, {});
});

it("should return one rule meta when there is a linting error", async () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/eslint/flat-eslint.js
View file
Open in desktop
Expand Up @@ -3726,7 +3726,7 @@ describe("FlatESLint", () => {

const rulesMeta = engine.getRulesMetaForResults([]);

assert.strictEqual(Object.keys(rulesMeta).length, 0);
assert.deepStrictEqual(rulesMeta, {});
});

it("should return one rule meta when there is a linting error", async () => {
Expand Down