Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Stylelint declaration-block-no-redundant-longhand-properties #16499

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 4, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make?

Enable the rule, and manually combine the 2 properties into the shorthand https://developer.mozilla.org/en-US/docs/Web/CSS/flex-flow

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added documentation Relates to ESLint's documentation triage An ESLint team member will look at this issue soon labels Nov 4, 2022
@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 498e20c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6366d92a9d720200089f3922
😎 Deploy Preview https://deploy-preview-16499--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nschonni nschonni force-pushed the declaration-block-no-redundant-longhand-properties branch from 802da76 to 498e20c Compare November 5, 2022 21:44
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should restrict this behavior. I would like to hear more opinions from @eslint/website-team

@snitin315 snitin315 added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Nov 6, 2022
@kecrily
Copy link
Member

kecrily commented Nov 6, 2022

I prefer not to use shorthand because longhand properties are more explicit for people who don't particularly know css or suddenly forget the order in which shorthand properties correspond.


But this will obviously also increase the size of the css file, but for now it's just a little bit for us. Or could we use postcss to merge them?

@snitin315
Copy link
Contributor

snitin315 commented Nov 11, 2022

I prefer not to use shorthand because longhand properties are more explicit for people who don't particularly know css or suddenly forget the order in which shorthand properties correspond.

Yeah, I feel the same here. Let's close this one.

But this will obviously also increase the size of the css file, but for now it's just a little bit for us. Or could we use postcss to merge them?

@kecrily There is a PR for PostCSS, you may want to review #16502

@snitin315 snitin315 closed this Nov 11, 2022
@nschonni nschonni deleted the declaration-block-no-redundant-longhand-properties branch November 11, 2022 03:27
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 11, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants