Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: autofix recursive functions in no-var #16611

Merged
merged 1 commit into from Dec 8, 2022
Merged

fix: autofix recursive functions in no-var #16611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/no-var.js
View file
Open in desktop
Expand Up @@ -159,7 +159,7 @@ function hasReferenceInTDZ(node) {
return !reference.init && (
start < idStart ||
(defaultValue !== null && start >= defaultStart && end <= defaultEnd) ||
(start >= initStart && end <= initEnd)
(!astUtils.isFunction(node) && start >= initStart && end <= initEnd)
);
});
};
Expand Down
68 changes: 68 additions & 0 deletions tests/lib/rules/no-var.js
View file
Open in desktop
Expand Up @@ -319,6 +319,74 @@ ruleTester.run("no-var", rule, {
code: "function foo() { var { let } = {}; }",
output: null,
errors: [{ messageId: "unexpectedVar" }]
},

// https://github.com/eslint/eslint/issues/16610
{
code: "var fx = function (i = 0) { if (i < 5) { return fx(i + 1); } console.log(i); }; fx();",
amareshsm marked this conversation as resolved.
Show resolved Hide resolved
output: "let fx = function (i = 0) { if (i < 5) { return fx(i + 1); } console.log(i); }; fx();",
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var foo = function () { foo() };",
output: "let foo = function () { foo() };",
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var foo = () => foo();",
output: "let foo = () => foo();",
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var foo = (function () { foo(); })();",
output: null,
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var foo = bar(function () { foo(); });",
output: null,
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var bar = foo, foo = function () { foo(); };",
output: null,
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var bar = foo; var foo = function () { foo(); };",
output: "let bar = foo; var foo = function () { foo(); };",
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [
{ messageId: "unexpectedVar" },
{ messageId: "unexpectedVar" }
]
},
{
code: "var { foo = foo } = function () { foo(); };",
output: null,
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var { bar = foo, foo } = function () { foo(); };",
output: null,
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [{ messageId: "unexpectedVar" }]
},
{
code: "var bar = function () { foo(); }; var foo = function() {};",
output: "let bar = function () { foo(); }; var foo = function() {};",
parserOptions: { ecmaVersion: 6, sourceType: "module" },
errors: [
{ messageId: "unexpectedVar" },
{ messageId: "unexpectedVar" }
]
}
]
});