New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix language option styling #16636
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Wasn't it part of design? I thought it was part of design 😅 |
No, it's not a part of the design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Absolutely that's a visual regression my pr introduced. |
Can we change this line to use “pre” instead of “div” and then revert the CSS? |
Hi Nicholas, I'm afraid we can't simply change that and revert the respective css changes. The default
which would introduce another styling problem. It's possible to keep the original css class if I didn't implement the |
Ah I see. I'm just not a fan of using |
Class name collisions seem inevitable when they're semantic :), especially when we have many contributors in open source projects. How about renaming |
Yes but we didn't have any until this change. :) Managing exclusions tends to cause errors in the long-run because you need to keep track of them. Can't we just add the |
Sure. That was my plan when I said above I can file another pull request to update it: |
@amareshsm shall we close this in favour of #16669 I think both of the PRs are solving the same problem? |
yes once the PR is ready we check and close this PR. |
Closing this in favor of #16669 |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Fixed language option styling.
What changes did you make? (Give an overview)
Due to the style change (
pre[class*="language-"]
todiv[class*="language-"]
-syntax-highlighter.scss
) in #16606, language option styles were affected. Fixed by excluding the.language-switcher
class.