Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning eslint-disable-line #16756

Closed
wants to merge 1 commit into from
Closed

Conversation

fhightower
Copy link

I expected to find eslint-disable-line mentioned on this page and I noticed that eslint-disable-line is never explicitly documented from what I could find (although it's noted in numerous examples). I think it would be helpful to mention it on this page which discusses how to ignore code. Thanks!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

I expected to find `eslint-disable-line` mentioned on this page and I noticed that `eslint-disable-line` is never explicitly documented from what I could find (although it's noted in numerous examples). I think it would be helpful to mention it on this page which discusses how to ignore code. Thanks!
@linux-foundation-easycla
Copy link

CLA Not Signed

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jan 6, 2023
@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit d824964
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/63b898146da058000a743759
😎 Deploy Preview https://deploy-preview-16756--docs-eslint.netlify.app/user-guide/configuring/ignoring-code
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@eslint-github-bot
Copy link

Hi @fhightower!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@bmish
Copy link
Sponsor Member

bmish commented Jan 6, 2023

It looks like the "ignoring code" doc is more about ignoring files than actual lines of code?

I agree that from the name "ignoring code" one might expect to be able to find information about ignoring lines of code.

Maybe adding small section at the bottom of the doc that links to Using Configuration Comments would be worthwhile? For increasing discoverability while not duplicating content from the other doc.

Wherever the source of truth for these disable directives ends up living, it seems like it would be helpful to a have a bullet-point list of all the types of disable directive comments. I see such a list in yet another doc's sections called Inline Configuration Comments. In my mind, there would be one section about all this that every other page can link to.

@mdjermanovic
Copy link
Member

Yes, this document is only about specifying files that ESLint should just skip. eslint-disable-line is a different concept.

I agree with @bmish that "ignoring code" is a confusing name for this, and I think we should change the title and navigation item when implementing #16720. @bpmutter what do you think?

@bpmutter
Copy link
Contributor

Yes, this document is only about specifying files that ESLint should just skip. eslint-disable-line is a different concept.

I agree with @bmish that "ignoring code" is a confusing name for this, and I think we should change the title and navigation item when implementing #16720. @bpmutter what do you think?

i agree that the current name is confusing, and it would make more sense to rename the page 'Ignore Files' as part of #16720. will do that. (doesn't hurt that it's a very small change, as well)

@snitin315
Copy link
Contributor

Recently the title was changed to ignore files in #16760 which should avoid such confusion in the future.

@fhightower Thanks for bringing it up, closing this PR as resolved.

@snitin315 snitin315 closed this Feb 8, 2023
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Aug 8, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants