Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update stale bot settings #16870

Merged
merged 2 commits into from Feb 12, 2023
Merged

chore: Update stale bot settings #16870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
769749f
chore: Update stale bot settings
nzakas Feb 7, 2023
42413dc
Incorporate feedback
nzakas Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/stale.yml
View file
Open in desktop
Expand Up @@ -21,10 +21,12 @@ jobs:
- uses: actions/stale@v7
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: 60
days-before-issue-stale: 30
days-before-pr-stale: 10
days-before-close: 7
nzakas marked this conversation as resolved.
Show resolved Hide resolved
stale-issue-message: 'Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update.'
stale-pr-message: 'Oops! It looks like we lost track of this pull request. What do we want to do here? This pull request will auto-close in 7 days without an update.'
close-issue-message: 'This issue was auto-closed due to inactivity. While we wish we could keep responding to every issue, we unfortunately don''t have the bandwidth and need to focus on high-value issues.'
snitin315 marked this conversation as resolved.
Show resolved Hide resolved
stale-pr-message: 'Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.'
close-pr-message: 'This pull request was auto-closed due to inactivity. While we wish we could keep working on every request, we unfortunately don''t have the bandwidth to continue here and need to focus on other things. You can resubmit this pull request if you would like to continue working on it.'
exempt-all-assignees: true
exempt-issue-labels: accepted
exempt-pr-labels: accepted
6 changes: 3 additions & 3 deletions docs/src/maintain/review-pull-requests.md
View file
Open in desktop
Expand Up @@ -92,16 +92,16 @@ If the pull request was created from a branch on the `eslint/eslint` repository
There are several times when it's appropriate to close a pull request without merging:

1. The pull request addresses an issue that is already fixed
1. The pull request hasn't been updated in 30 days
1. The pull request hasn't been updated in 17 days
1. The pull request submitter isn't willing to follow project guidelines.

In any of these cases, please be sure to leave a comment stating why the pull request is being closed.

### Example Closing Comments

If a pull request hasn't been updated in 30 days:
If a pull request hasn't been updated in 17 days:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason we are using 17 days? Also Im not sure but this feels very less compared to the last duration of 30 days 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason we are using 17 days?

10 + 7. Bot adds the Stale label and comment after 10 days of inactivity, then closes the PR after another 7 days if there is still no activity.


> Closing because there hasn't been activity for 30 days. If you're still interested in submitting this code, please feel free to resubmit.
> Closing because there hasn't been activity for 17 days. If you're still interested in submitting this code, please feel free to resubmit.
If a pull request submitter isn't willing to follow project guidelines.

Expand Down