Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: docs license" #17231

Merged
merged 1 commit into from Jun 5, 2023
Merged

Revert "feat: docs license" #17231

merged 1 commit into from Jun 5, 2023

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented May 30, 2023 •
edited

Reverts #17010
Refs #17225 step3

@aladdin-add aladdin-add requested a review from a team as a code owner May 30, 2023 08:37
@netlify
Copy link

netlify bot commented May 30, 2023 •
edited

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 46c4645
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6475b5c710e3760008ec457c
😎 Deploy Preview https://deploy-preview-17231--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aladdin-add aladdin-add mentioned this pull request May 30, 2023
Closed
@stbischof
Copy link
Contributor

Thank you very much!

mdjermanovic
mdjermanovic approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I believe merging should wait for #17227 to be merged first.

nzakas
nzakas approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And yes, let's merge #17227 first.

@mdjermanovic mdjermanovic mentioned this pull request Jun 2, 2023
Merged
16 tasks
@mdjermanovic mdjermanovic merged commit 030a827 into main Jun 5, 2023
22 checks passed
@mdjermanovic mdjermanovic deleted the revert-17010-docs-license branch June 5, 2023 20:50
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 3, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aladdin-add @stbischof @nzakas @mdjermanovic